remove append #261
Merged
remove append #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Irv
reviewed
Sep 4, 2022
twoertwein
commented
Sep 4, 2022
tests/test_series.py
Outdated
| def test_getattr() -> None: | ||
| # GH 261 | ||
| series = pd.Series([1, 2, 3], index=["a", "b", "c"], dtype=int) | ||
| check(assert_type(series.a, int), np.int64) |
There was a problem hiding this comment.
unfortunately, it doesn't return a builtin int
|
The error on windows could be a pandas/numpy inconsistency. It seems that our windows CI is 64bit (np.intp is np.int64) but the observed dtype is np.int32. |
Dr-Irv
requested changes
Sep 5, 2022
pandas-stubs/core/generic.pyi
Outdated
| @@ -359,7 +360,7 @@ class NDFrame(PandasObject, indexing.IndexingMixin): | |||
| self, func: Callable[..., T] | tuple[Callable[..., T], str], *args, **kwargs | |||
| ) -> T: ... | |||
| def __finalize__(self, other, method=..., **kwargs) -> NDFrame: ... | |||
| def __getattr__(self, name: _str): ... | |||
| def __getattr__(self, name: _str) -> Series: ... | |||
There was a problem hiding this comment.
Move this to core/frame.pyi and you can avoid the # type: ignore in core/series.pyi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As long as a class as
__getattr__exist, mypy and pyright assume that.append(and any other non-existing method) might still exists. Removing__getattr__has the disadvantage that users can no longer dodf.column_name.